lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Oct 2010 15:26:05 -0700 From: Dan Williams <dan.j.williams@...el.com> To: Vasiliy Kulikov <segooon@...il.com> Cc: kernel-janitors@...r.kernel.org, Sascha Hauer <s.hauer@...gutronix.de>, Linus Walleij <linus.walleij@...ricsson.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] dma: imx-dma: fix signedness bug On Sun, Oct 17, 2010 at 7:51 AM, Vasiliy Kulikov <segooon@...il.com> wrote: > mxdmac->channel was unsigned, so check (imxdmac->channel < 0) for > failed imx_dma_request_by_prio() made no sence. Explicitly check > signed values. > > Signed-off-by: Vasiliy Kulikov <segooon@...il.com> > --- > drivers/dma/imx-dma.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c > index 346be62..75d870f 100644 > --- a/drivers/dma/imx-dma.c > +++ b/drivers/dma/imx-dma.c > @@ -335,7 +335,7 @@ static int __init imxdma_probe(struct platform_device *pdev) > > imxdmac->imxdma_channel = imx_dma_request_by_prio("dmaengine", > DMA_PRIO_MEDIUM); > - if (imxdmac->channel < 0) > + if ((int)imxdmac->channel < 0) > goto err_init; Should this be: if ((int)imxdmac->channel < 0) { ret = -ENODEV; goto err_init; } ...because I get the following in my compilation tests. drivers/dma/imx-dma.c: In function 'imxdma_probe': drivers/dma/imx-dma.c:324: warning: 'ret' may be used uninitialized in this function -- Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists