| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTimdFBLHXh0neU4j3aKf4u1rrOjVmNB+qHcRbmkr@mail.gmail.com> Date: Wed, 20 Oct 2010 14:27:13 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Greg KH <greg@...ah.com> Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de> Subject: Re: [PATCH 1/3] staging: batman-adv: remove useless addr_to_string() Sorry for that. Resend new version checked by both compilation and sparse. On Tue, Oct 19, 2010 at 8:03 PM, Greg KH <greg@...ah.com> wrote: > On Sat, Oct 16, 2010 at 01:11:10PM +0300, Andy Shevchenko wrote: >> Since all *printf() methods in the kernel understand '%pM' modifier the >> conversion to the string is useless beforehand. >> >> Additionally this patch decreases batman_if structure by 20 bytes. > > And also, it breaks the build: > drivers/staging/batman-adv/vis.c: In function ‘vis_data_read_entry’: > drivers/staging/batman-adv/vis.c:170:38: error: ‘to’ undeclared (first use in this function) > drivers/staging/batman-adv/vis.c:170:38: note: each undeclared identifier is reported only once for each function it appears in > > Please always test your patches :( > > I've dropped this one. > > thanks, > > greg k-h > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists