linux-kernel - Re: [patch 08/35] fs: icache lock i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101020021457.GA3740@amd>
Date:	Wed, 20 Oct 2010 13:14:57 +1100
From:	Nick Piggin <npiggin@...nel.dk>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	npiggin@...nel.dk, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [patch 08/35] fs: icache lock i_count

On Tue, Oct 19, 2010 at 12:16:51PM +0200, Boaz Harrosh wrote:
> On 10/19/2010 05:42 AM, npiggin@...nel.dk wrote:
> > Protect inode->i_count with i_lock, rather than having it atomic.
> > 
> > Signed-off-by: Nick Piggin <npiggin@...nel.dk>
> > 
> > ---
> <>
> >  fs/exofs/inode.c                         |   12 +++++++---
> >  fs/exofs/namei.c                         |    4 ++-
> <>
> > Index: linux-2.6/fs/exofs/inode.c
> > ===================================================================
> > --- linux-2.6.orig/fs/exofs/inode.c	2010-10-19 14:17:26.000000000 +1100
> > +++ linux-2.6/fs/exofs/inode.c	2010-10-19 14:19:18.000000000 +1100
> > @@ -1107,7 +1107,9 @@
> >  
> 
> Hi Nick, Please use -p option in your diff(s) it is a bit hard to follow
> and review without the proper function context. These patches are on a git
> tree. Why don't you use git to produce and send these patches?

Yes, sorry that was a big mistake. New computer, I don't know why it
doesn't do that as default option.

Thanks,
Nick


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/