linux-kernel - Re: [PATCH] drivers/hwmon: Use pr_fmt and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1287593660.1813.198.camel@Joe-Laptop>
Date:	Wed, 20 Oct 2010 09:54:20 -0700
From:	Joe Perches <joe@...ches.com>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Hans de Goede <j.w.r.degoede@....nl>,
	Alistair John Strachan <alistair@...zero.co.uk>,
	Henrik Rydberg <rydberg@...omail.se>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Luca Tettamanti <kronos.it@...il.com>,
	Fenghua Yu <fenghua.yu@...el.com>,
	Juerg Haefliger <juergh@...il.com>,
	Eric Piel <eric.piel@...mplin-utc.net>,
	Jim Cromie <jim.cromie@...il.com>,
	Roger Lucas <vt8231@...denengine.co.uk>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level>

On Wed, 2010-10-20 at 09:49 -0700, Guenter Roeck wrote:
> On Wed, Oct 20, 2010 at 11:59:23AM -0400,
>  Joe Perches wrote:
> [ ... ]
> > Anyway, I'd like to sort it out eventually.
> > For now, I just add the #define pr_fmt, with
> > a long term goal of removing them all and using
> > a different mechanism to remove the duplicated
> > prefix string altogether from the formats and
> > save some text.
> I don't mind individual pr_fmt defines as long as they are used.
> However, that is not the case in many of the patches.
> Just adding a pr_fmt define to a file without using it doesn't make sense to me.

kernel.h has the equivalent of:

#define pr_<level>(fmt, arg...) printk(KERN_<level> pr_fmt(fmt), ##arg)

so the added "#define pr_fmt(fmt)..."s are used
wherever pr_<level> is done.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/