linux-kernel - Re: [patch 26/35] fs: icache alloc anonymous inode allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101020023828.GE3740@amd>
Date:	Wed, 20 Oct 2010 13:38:28 +1100
From:	Nick Piggin <npiggin@...nel.dk>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	npiggin@...nel.dk, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [patch 26/35] fs: icache alloc anonymous inode allocation

On Tue, Oct 19, 2010 at 05:50:00PM +0200, Miklos Szeredi wrote:
> On Tue, 19 Oct 2010, npiggin@...nel.d wrote:
> > Index: linux-2.6/fs/anon_inodes.c
> > ===================================================================
> > --- linux-2.6.orig/fs/anon_inodes.c	2010-10-19 14:18:58.000000000 +1100
> > +++ linux-2.6/fs/anon_inodes.c	2010-10-19 14:19:19.000000000 +1100
> > @@ -191,7 +191,7 @@
> >   */
> >  static struct inode *anon_inode_mkinode(void)
> >  {
> > -	struct inode *inode = new_inode(anon_inode_mnt->mnt_sb);
> > +	struct inode *inode = new_anon_inode(anon_inode_mnt->mnt_sb);
> >  
> >  	if (!inode)
> >  		return ERR_PTR(-ENOMEM);
> 
> This too needs an inode->i_ino initialization (the default ULONG_MAX
> will cause EOVERFLOW on 32bit fstat, AFAIK), though it could just be a
> constant, say 2.

OK. I'll add a #define for it. Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/