linux-kernel - Re: [PATCH v3] i2c/mux: Driver for PCA9541 I2C Master Selector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Oct 2010 17:11:20 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Ben Dooks <ben-linux@...ff.org>,
	Rodolfo Giometti <giometti@...ux.it>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] i2c/mux: Driver for PCA9541 I2C Master Selector

On Thu, 21 Oct 2010 08:03:00 -0700, Guenter Roeck wrote:
> On Thu, Oct 21, 2010 at 10:43:04AM -0400, Jean Delvare wrote:
> > On Tue, 19 Oct 2010 20:55:08 -0700, Guenter Roeck wrote:
> > > This patch adds support for PCA9541, an I2C Bus Master Selector.
> > > The driver is modeled as single channel I2C Multiplexer to be able to utilize
> > > the I2C multiplexer framework.
> > > 
> > > Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com>
> > > Reviewed-by: Tom Grennan <tom.grennan@...csson.com>
> > > ---
> > > v3 changes:
> > > - Clarified and cleaned up comments.
> > > - No longer pass "struct i2c_adapter *" as parameter.
> > >   Get it from client->adapter if needed.
> > > - No longer pass "struct pca9541 *" as parameter. 
> > >   Pass "struct i2c_client *" instead and get "struct pca9541 *" from it
> > >   if needed.
> > > - Removed "struct i2c_client *client" from struct pca9541 since it is
> > >   no longer needed.
> > > - Moved "pca9541_release_bus(client);" ahead of i2c_add_mux_adapter()
> > >   to avoid a possible race condition. Also protect the call with
> > >   i2c_lock_adapter() / i2c_unlock_adapter().
> > > - Removed __devinit from pca9541_probe() and __devexit from pca9541_remove().
> > 
> > Applied, thanks.
> > 
> > Would you mind adding yourself to MAINTAINERS as a maintainer for this
> > driver? While the driver is small, it's not trivial and it's difficult
> > to work on it without the right hardware setup.
> > 
> Sure. Not intentional - I wanted to do that, just forgot. And I agree,
> it is pretty much impossible to maintain it unless you have HW to test it.
> 
> Want me to resubmit or send a separate patch ?

Separate patch, I'll merge them if needs be.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/