linux-kernel - Re: [PATCH v2] POWER: Add gpio charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC07CB4.9060108@metafoo.de>
Date:	Thu, 21 Oct 2010 19:47:32 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Anton Vorontsov <cbouatmailru@...il.com>
CC:	rklein@...dia.com, broonie@...nsource.wolfsonmicro.com,
	achew@...dia.com, olof@...om.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] POWER: Add gpio charger driver

Anton Vorontsov wrote:
> On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:
>> This patch adds a simple driver for chargers indicating their online status
>> through a GPIO pin.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> 
> Hm. I'm getting older, it seems. Now can anybody remind me why
> pda_power.c doesn't work here? ;-)
> 
> This driver looks like a light-weigh version of pda_power, except
> that it can do GPIOs directly (instead of is_*_online() callbacks).
> 
> Can we instead improve pda_power? Like this:
> 
> 	if (!pdata->is_ac_online && pdata->ac_monitor_gpio)
> 		pdata->is_ac_online = pda_ac_monitor_gpio;
> 
> Should look quite cool, I think.
> 
> (Plus, we might get rid of ac/usb stuff in that driver, and 
> pass enum power_supply_type to the callbacks instead).
> 

Hi

Hm... I guess it can be, but on the other hand most platform bus chargers type
devices can be, because the pda_power driver is keep pretty generic with custom init,
status and exit callbacks.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/