linux-kernel - Re: [PATCH] gpio led: properly initialize return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1287696074.2075.4.camel@cowboy>
Date:	Thu, 21 Oct 2010 18:21:14 -0300
From:	Davidlohr Bueso <dave@....org>
To:	rpurdie@...ys.net
Cc:	raph@...com, tpiepho@...escale.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio led: properly initialize return value

On Mon, 2010-10-18 at 12:53 -0300, Davidlohr Bueso wrote:
> gpio led: properly initialize return value in gpio_led_init()
> 
> In the event that none of the configs are set (CONFIG_LEDS_GPIO_PLATFORM, CONFIG_LEDS_GPIO_OF, 
> CONFIG_LEDS_GPIO_PLATFORM), we will return bogus when initializing the module.
> 

Signed-off-by: Davidlohr Bueso <dave@....org>
Cc: Richard Purdie <rpurdie@...ys.net>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

> Signed-off-by: Davidlohr Bueso <dave@....org>
> ---
>  drivers/leds/leds-gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index ea57e05..4d9fa38 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -316,7 +316,7 @@ static struct of_platform_driver of_gpio_leds_driver = {
>  
>  static int __init gpio_led_init(void)
>  {
> -	int ret;
> +	int ret = 0;
>  
>  #ifdef CONFIG_LEDS_GPIO_PLATFORM	
>  	ret = platform_driver_register(&gpio_led_driver);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/