linux-kernel - Re: [PATCH] lib/atomic64_test: do not build on non-atomic64 systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101021150250.f6499506.akpm@linux-foundation.org>
Date:	Thu, 21 Oct 2010 15:02:50 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Luca Barbieri <luca@...a-barbieri.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/atomic64_test: do not build on non-atomic64 systems

On Sat, 16 Oct 2010 13:27:15 -0400
Mike Frysinger <vapier@...too.org> wrote:

> If the arch doesn't provide atomic64 functionality (there are quite a
> few), then don't bother trying to build this test.
> 

I don't get it.  If the arch doesn't implement atomic64 then this file
will get zillions of build errors, won't it?

> diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
> index 250ed11..0ac1a66 100644
> --- a/lib/atomic64_test.c
> +++ b/lib/atomic64_test.c
> @@ -12,6 +12,8 @@
>  #include <linux/kernel.h>
>  #include <asm/atomic.h>
>  
> +#ifdef ATOMIC64_INIT

hm, that's a bit lazy.  It should really use a CONFIG_HAVE_ thing.  What
a pita.

>  #define INIT(c) do { atomic64_set(&v, c); r = c; } while (0)
>  static __init int test_atomic64(void)
>  {
> @@ -164,3 +166,5 @@ static __init int test_atomic64(void)
>  }
>  
>  core_initcall(test_atomic64);
> +
> +#endif
> -- 
> 1.7.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/