linux-kernel - Re: [PATCH] mfd: Fix resource reclaim in pcf50633

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101021225457.GE11685@sortiz-mobl>
Date:	Fri, 22 Oct 2010 00:54:57 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Harald Welte <laforge@...nmoko.org>
Subject: Re: [PATCH] mfd: Fix resource reclaim in pcf50633_remove()

Hi Axel,

On Wed, Oct 20, 2010 at 04:56:59PM +0800, Axel Lin wrote:
> Calling sysfs_remove_group() to remove sysfs entries
> and unregister bl_pdev in pcf50633_remove().
patch applied, thanks.

Cheers,
Samuel.


> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/pcf50633-core.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6d4233f..501ce13 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -339,12 +339,14 @@ static int __devexit pcf50633_remove(struct i2c_client *client)
>  	struct pcf50633 *pcf = i2c_get_clientdata(client);
>  	int i;
>  
> +	sysfs_remove_group(&client->dev.kobj, &pcf_attr_group);
>  	pcf50633_irq_free(pcf);
>  
>  	platform_device_unregister(pcf->input_pdev);
>  	platform_device_unregister(pcf->rtc_pdev);
>  	platform_device_unregister(pcf->mbc_pdev);
>  	platform_device_unregister(pcf->adc_pdev);
> +	platform_device_unregister(pcf->bl_pdev);
>  
>  	for (i = 0; i < PCF50633_NUM_REGULATORS; i++)
>  		platform_device_unregister(pcf->regulator_pdev[i]);
> -- 
> 1.7.2
> 
> 
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/