linux-kernel - Re: [PATCH 1/2] tracing: Prevent unloadable modules from using trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101021035444.GH5387@nowhere>
Date:	Thu, 21 Oct 2010 05:54:46 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] tracing: Prevent unloadable modules from using
	trace_bprintk()

On Wed, Oct 20, 2010 at 11:47:56PM -0400, Steven Rostedt wrote:
> On Thu, 2010-10-21 at 05:42 +0200, Frederic Weisbecker wrote:
> 
> > > +/*
> > > + * Module code must not use trace_bprintk, because if it is unloaded
> > > + * then we leave a pointer back to the module code inside
> > > + * the ring buffer, and then reading the ring buffer may cause a bug.
> > > + *
> > > + * We do allow for modules to use it if the kernel does not allow
> > > + * unloading of modules, and MODVERSIONS is set (to make sure kernel
> > > + * and module are the same). If you load modules without MODVERSIONS
> > > + * set, then you deserve what you get.
> > > + */
> > > +#if defined(MODULE) &&							\
> > 
> > 
> > 
> > Did you mean CONFIG_MODULE may be?
> 
> Nope, then the a kernel that allows modules wont use it. I do mean
> "MODULE", as in defined by the Makefile:
> 
> KBUILD_AFLAGS_MODULE  := -DMODULE
> KBUILD_CFLAGS_MODULE  := -DMODULE


Ah ok.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/