| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Oct 2010 08:30:26 +0800 From: Axel Lin <axel.lin@...il.com> To: linux-kernel <linux-kernel@...r.kernel.org> Cc: Samuel Ortiz <sameo@...ux.intel.com>, Kyungmin Park <kyungmin.park@...sung.com> Subject: [PATCH 1/2] mfd: Remove unneeded ret value checking i2c_smbus_write_byte_data() returns zero or negative value, therefore no need to check if ret is greater than zero or not. Signed-off-by: Axel Lin <axel.lin@...il.com> --- drivers/mfd/max8998.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c index a720f41..06ddf74 100644 --- a/drivers/mfd/max8998.c +++ b/drivers/mfd/max8998.c @@ -110,8 +110,6 @@ int max8998_update_reg(struct i2c_client *i2c, u8 reg, u8 val, u8 mask) u8 old_val = ret & 0xff; u8 new_val = (val & mask) | (old_val & (~mask)); ret = i2c_smbus_write_byte_data(i2c, reg, new_val); - if (ret >= 0) - ret = 0; } mutex_unlock(&max8998->iolock); return ret; -- 1.7.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists