lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Oct 2010 08:22:35 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	<mingo@...e.hu>, <tglx@...utronix.de>, <hpa@...or.com>
Cc:	<heukelum@...tmail.fm>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] i386: restore parentheses around one pushl_cfi
	 argument

These were (intentionally) stripped by "fix CFI macro invocations to
deal with shortcomings in gas" to expose problems with unexpected
splitting of arguments by older gas also on newer versions, but as it
turns out there is at least one distro (Ubuntu 6.06) where even not
having *any* spaces in a macro argument doesn't reliably prevent
splitting into multiple arguments.

Signed-off-by: Jan Beulich <jbeulich@...ell.com>
Acked-by: Alexander van Heukelum <heukelum@...tmail.fm>

---
 arch/x86/kernel/entry_32.S        |    2 +-
 1 files changed, 1 insertion, 1 deletion

--- 2.6.36-x86-cfi.orig/arch/x86/kernel/entry_32.S
+++ 2.6.36-x86-cfi/arch/x86/kernel/entry_32.S
@@ -395,7 +395,7 @@ sysenter_past_esp:
 	 * A tiny bit of offset fixup is necessary - 4*4 means the 4 words
 	 * pushed above; +8 corresponds to copy_thread's esp0 setting.
 	 */
-	pushl_cfi TI_sysenter_return-THREAD_SIZE_asm+8+4*4(%esp)
+	pushl_cfi (TI_sysenter_return-THREAD_SIZE_asm+8+4*4)(%esp)
 	CFI_REL_OFFSET eip, 0
 
 	pushl_cfi %eax



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ