linux-kernel - [PATCH] rcu: force all adopted callbacks are invoked before next cpu-offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4CC149E5.60901@cn.fujitsu.com>
Date:	Fri, 22 Oct 2010 16:23:01 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] rcu: force all adopted callbacks are invoked before next
 cpu-offline


When cpu-offline/online happen continuously, a CPU may
adopts too much callbacks or some callbacks are just
moved back and forth without invoked.

It will cause a CPU has a lot of burden or some callbacks
are invoked very late or starvation.

Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
---
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 669d7fe..8af45d6 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1811,6 +1811,23 @@ static int __cpuinit rcu_cpu_notify(struct notifier_block *self,
 	case CPU_UP_CANCELED_FROZEN:
 		rcu_offline_cpu(cpu);
 		break;
+	case CPU_POST_DEAD:
+	case CPU_POST_DEAD | CPU_TASKS_FROZEN:
+		/*
+		 * When a cpu is offline, the callbacks in the offline CPU
+		 * are orphaned and adopted by a online CPU. These callbacks
+		 * are processed as new inserted one. So in the worst case,
+		 * if the offline/online happen continuously, a CPU may
+		 * adopts too much callbacks or some callbacks are just
+		 * moved back and forth without invoked.
+		 *
+		 * To fix it, we must force all adopted callbacks are invoked
+		 * before next cpu-offline.
+		 */
+		rcu_barrier_bh();
+		rcu_barrier_sched();
+		rcu_barrier();
+		break;
 	default:
 		break;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/