linux-kernel - Re: Finishing off cpumask...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201010221032.42687.rusty@rustcorp.com.au>
Date:	Fri, 22 Oct 2010 10:32:42 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Mike Travis <travis@....com>,
	anton@...ba.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: Finishing off cpumask...

On Thu, 21 Oct 2010 07:51:47 pm Peter Zijlstra wrote:
> On Thu, 2010-10-21 at 17:35 +1030, Rusty Russell wrote:
> > The next two turn off and break
> > old-style cpumask uses when CONFIG_CPUMASK_OFFSTACK is set, 
> 
> Breaking old style for !CONFIG_CPUMASK_OFFSTAK too would be awesome, but
> I guess that's hard to do?

There are four things we could do.
(1) Get rid of the old cpus_ operators (=> cpumask_*).  They're just
    confusing, and  removing them would be a clarity win.
(2) Get rid of cpu_*_map (=> cpu_*_mask).  The maps are just wrappers.
(3) Getting rid of cpumask_t (=> struct cpumask) and NR_CPUS
    (=> CONFIG_NR_CPUS). These are totally cosmetic.
(4) Getting rid of cpumask_t/struct cpumask (=> cpumask_var_t) is basically
    only useful if an arch is thinking about CPUMASK_OFFSTACK, and most
    painful.

So, I've changed the CONFIG option which disables (1) and (2); now anyone
will be able to turn it on if they want to test.  That might encourage
the per-arch cleanup...

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/