linux-kernel - Re: [PATCHv4 4/4] iommu: create new api to set valid da range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikCsBCoT55BXvSJEkKYh8M0mMLBag_MR4-aBsEk@mail.gmail.com>
Date:	Fri, 22 Oct 2010 12:59:13 +0300
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	"Guzman Lugo, Fernando" <fernando.lugo@...com>
Cc:	"Hiroshi.DOYU@...ia.com" <Hiroshi.DOYU@...ia.com>,
	"felipe.contreras@...ia.com" <felipe.contreras@...ia.com>,
	"david.cohen@...ia.com" <david.cohen@...ia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>
Subject: Re: [PATCHv4 4/4] iommu: create new api to set valid da range

On Wed, Oct 20, 2010 at 7:26 PM, Felipe Contreras
<felipe.contreras@...il.com> wrote:
> On Wed, Oct 20, 2010 at 6:22 PM, Guzman Lugo, Fernando
> <fernando.lugo@...com> wrote:
>>> On Wed, Oct 20, 2010 at 5:48 AM, Fernando Guzman Lugo
>>> <x0095840@...com> wrote:
>>> > Some IOMMUs cannot use the whole 0x0 - 0xFFFFFFFF range.
>>> > With this new API the valid range can be set.
>>> >
>>> > Signed-off-by: Fernando Guzman Lugo <x0095840@...com>
>>>
>>> I don't see the point in having an API. It could be done
>>
>> Thanks to this api we can make this:
>>
>> A new kconfig parameter for DMM size is added. Also DMM is
>> allocated in the last part of the IVA MMU capable address.
>> So that DMM address are far away of shared memory address
>> reducing the probability of shared memory corruption.
>
> Ok, that's why it's usually a good idea to send a patch that makes use
> of the new API.

Oh, and some more comments: Hiroshi wanted the end address too, but
also on the platform data.

And please use a sensible prefix, like "omap: iommu: ", if you only do
"iommu: " it can be confused with other parts of the system, specially
if you send to lkml.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/