linux-kernel - Re: [alsa-devel] HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC17629.6050703@ladisch.de>
Date:	Fri, 22 Oct 2010 13:31:53 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Jiri Slaby <jirislaby@...il.com>
CC:	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	mm-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	Valdis.Kletnieks@...edu, akpm@...ux-foundation.org
Subject: Re: [alsa-devel] HDA: no sound [was: mmotm 2010-10-20-15-01	uploaded]

Jiri Slaby wrote:
> On 10/21/2010 10:05 AM, Takashi Iwai wrote:
> >   commit de8c85f7840e5e29629de95f5af24297fb325e0b
> >     ALSA: HDA: Sigmatel: work around incorrect master muting
> 
> Reverting this one helps.

This one introduced even more wrong volume information on some codecs.
Pleasy try this patch on top:

--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -32,6 +32,7 @@
 #include <sound/core.h>
 #include <sound/asoundef.h>
 #include <sound/jack.h>
+#include <sound/tlv.h>
 #include "hda_codec.h"
 #include "hda_local.h"
 #include "hda_beep.h"
@@ -1145,7 +1146,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
 		/* correct volume offset */
 		vmaster_tlv[2] += vmaster_tlv[3] * spec->volume_offset;
 		/* minimum value is actually mute */
-		vmaster_tlv[3] |= 0x1000;
+		vmaster_tlv[3] |= TLV_DB_SCALE_MUTE;
 		err = snd_hda_add_vmaster(codec, "Master Playback Volume",
 					  vmaster_tlv, slave_vols);
 		if (err < 0)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/