linux-kernel - Re: [PATCH v2][GIT PULL] tracing: Prevent unloadable modules from using trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1287755448.16971.631.camel@gandalf.stny.rr.com>
Date:	Fri, 22 Oct 2010 09:50:48 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [PATCH v2][GIT PULL] tracing: Prevent unloadable modules from
 using trace_bprintk()

On Fri, 2010-10-22 at 10:05 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > 
> > Ingo,
> > 
> > This is based off of my core-2 branch. I'm moved this patch after that
> > so if anyone has any objections, I can change this patch without holding
> > off the previous one.
> > 
> > Note, I made the TRACE_BPRINTK_ALLOWED change since it looks better.
> 
> Hm, it still looks rather fundamentally ugly, messy and assymetric. Please work out 
> some better solution with the module folks. If there's really no sane solution then 
> we better remove this 'speedup' API, it's just not worth it.

If something doesn't work, then I say we just prevent all modules from
using it. Why punish kernel code. The API is already dynamic, since it
only uses the speed up if the format is static. We could just add no
modules too.

But that said, I think we do have a solution that Li Zefan pointed out
(and something I'm ashamed about not coming up with, since it was indeed
the obvious solution).

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/