linux-kernel - Re: [PATCH v5] Add generic exponentially weighted moving average (EWMA) function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101022104057.53B2.A69D9226@jp.fujitsu.com>
Date:	Fri, 22 Oct 2010 10:42:41 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Bruno Randolf <br1@...fach.org>
Cc:	kosaki.motohiro@...fujitsu.com, randy.dunlap@...cle.com,
	akpm@...ux-foundation.org, peterz@...radead.org,
	blp@...stanford.edu, linux-kernel@...r.kernel.org,
	Lars_Ericsson@...ia.com, kevin.granade@...il.com
Subject: Re: [PATCH v5] Add generic exponentially weighted moving average (EWMA) function


only one nit.

> +/**
> + * ewma_init() - Initialize EWMA parameters
> + * @avg: Average structure
> + * @factor: Factor to use for the scaled up internal value. The maximum value
> + *	of averages can be UINT_MAX/(factor*weight).

			ULONG_MAX?


Anyway,
	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/