linux-kernel - Re: [PATCH] block2mtd: dubious assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101022143416.GA12737@logfs.org>
Date:	Fri, 22 Oct 2010 16:34:16 +0200
From:	Jörn Engel <joern@...fs.org>
To:	Nicolas Kaiser <nikai@...ai.net>
Cc:	Joern Engel <joern@...ybastard.org>, linux-mtd@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block2mtd: dubious assignment

On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
> 
> When block2mtd_erase fails, a duplicated assignment instantly
> changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
> 
> It looks to me like this might not be intended, or is it?

Definitely not.  Just proves how well block device errors are tested.

> Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
Acked-By: Joern Engel <joern@...fs.org>

Artem, can I leave this patch to you as well?

Jörn

-- 
Eighty percent of success is showing up.
-- Woody Allen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/