linux-kernel - Re: [PATCHv4 1/2] ARM: imx: Add gpio-keys to mx51 babbage board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87aam6b1g8.fsf@lechat.rtp-net.org>
Date:	Fri, 22 Oct 2010 19:07:51 +0200
From:	Arnaud Patard (Rtp) <arnaud.patard@...-net.org>
To:	Nguyen Dinh-R00091 <R00091@...escale.com>
Cc:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, amit.kucheria@...onical.com,
	linux@....linux.org.uk, s.hauer@...gutronix.de,
	linux-kernel@...r.kernel.org, grant.likely@...retlab.ca,
	valentin.longchamp@...l.ch, daniel@...aq.de,
	bryan.wu@...onical.com, Zhang Lily-R58066 <R58066@...escale.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCHv4 1/2] ARM: imx: Add gpio-keys to mx51 babbage board

Nguyen Dinh-R00091 <R00091@...escale.com> writes:

Hi,

[...]

>>> index e46b1c2..7ae27e8 100644
>>> --- a/arch/arm/plat-mxc/include/mach/iomux-mx51.h
>>> +++ b/arch/arm/plat-mxc/include/mach/iomux-mx51.h
>>> @@ -114,7 +114,7 @@ typedef enum iomux_config {
>>>  #define MX51_PAD_EIM_A24__GPIO_2_18             IOMUX_PAD(0x450, 0x0bc, 1, 0x0,   0, NO_PAD_CTRL)
>>>  #define MX51_PAD_EIM_A25__GPIO_2_19             IOMUX_PAD(0x454, 0x0c0, 1, 0x0,   0, NO_PAD_CTRL)
>>>  #define MX51_PAD_EIM_A26__GPIO_2_20             IOMUX_PAD(0x458, 0x0c4, 1, 0x0,   0, NO_PAD_CTRL)
>>> -#define MX51_PAD_EIM_A27__GPIO_2_21             IOMUX_PAD(0x45c, 0x0c8, 1, 0x0,   0, NO_PAD_CTRL)
>>> +#define MX51_PAD_EIM_A27__GPIO_2_21             IOMUX_PAD(0x45c, 0x0c8, 1, 0x0,   0,
>>MX51_GPIO_PAD_CTRL | PAD_CTL_PUS_100K_UP)
>>Is this a generic change valid for all mx51 machines or only for the
>>babbage board?
>
> This is a change that is probably valid for all mx51 machines, but I have only tested on Babbage. 

While I agree to change from NO_PAD_CTRL to MX51_GPIO_PAD_CTRL, I
believe that adding PAD_CTRL_PUS_100K_UP is not valid for all
machines. For instance, one may want PAD_CTL_PUS_47K_UP or no
pull-up at all because one has been added on the board.
Also, if it's generic, I'll be happy to understand why it has not been
added to MX51_GPIO_PAD_CTRL when MX51_GPIO_PAD_CTRL was added.

Regards,
Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/