linux-kernel - Re: [PATCH] percpu_counter : add percpu_counter_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101021191425.b94b0942.akpm@linux-foundation.org>
Date:	Thu, 21 Oct 2010 19:14:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Nick Piggin <npiggin@...nel.dk>
Cc:	Christoph Lameter <cl@...ux.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Dave Chinner <david@...morbit.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] percpu_counter : add percpu_counter_add_fast()

On Fri, 22 Oct 2010 12:58:45 +1100 Nick Piggin <npiggin@...nel.dk> wrote:

> > But what's really alarming is that the compiler (4.0.2) is cheerily
> > ignoring the inline directives and was generating out-of-line versions
> > of most of the percpu_counter.h functions into lib/proportions.s. 
> > That's rather a worry.
> 
> You you have the "ignore inlining"

# CONFIG_OPTIMIZE_INLINING is not set

> and "compile for size" turned on?

CONFIG_CC_OPTIMIZE_FOR_SIZE=y

> They often suck.

Everything sucks.  Are they any use?

With

# CONFIG_CC_OPTIMIZE_FOR_SIZE is not set
CONFIG_OPTIMIZE_INLINING=y

my kernel/built-in.o text went from 563638 bytes to 659852. 
That's rather a lot.

I haven't looked at this stuff in years.  Has anyone dug into it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/