[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CC1EBB6.5030500@colin.guthr.ie>
Date: Fri, 22 Oct 2010 20:53:26 +0100
From: Colin Guthrie <gmane@...in.guthr.ie>
To: Takashi Iwai <tiwai@...e.de>
CC: Clemens Ladisch <clemens@...isch.de>, alsa-devel@...a-project.org,
Valdis.Kletnieks@...edu, Jiri Slaby <jirislaby@...il.com>,
linux-kernel@...r.kernel.org, mm-commits@...r.kernel.org,
akpm@...ux-foundation.org
Subject: Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded]
'Twas brillig, and Takashi Iwai at 22/10/10 15:03 did gyre and gimble:
> At Fri, 22 Oct 2010 13:31:53 +0200,
> Clemens Ladisch wrote:
>>
>> Jiri Slaby wrote:
>>> On 10/21/2010 10:05 AM, Takashi Iwai wrote:
>>>> commit de8c85f7840e5e29629de95f5af24297fb325e0b
>>>> ALSA: HDA: Sigmatel: work around incorrect master muting
>>>
>>> Reverting this one helps.
>>
>> This one introduced even more wrong volume information on some codecs.
>> Pleasy try this patch on top:
>
> Argh! There is always a reason why we should define a constant.
> I applied the fix now.
>
> This explains why the old patch worked on Colin's machine.
> His codec chip is different (STAC9200?), and it doesn't go in this
> code path but has a static Master volume creation.
Yup I have a STAC9200 so that explains it... silly me as I did see this
line and figured "the value will be right" rather than questioning it.
Anyway, glad this has been found and there is now (presumably) no need
for a revert :)
Col
--
Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/
Day Job:
Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
Mageia Contributor [http://www.mageia.org/]
PulseAudio Hacker [http://www.pulseaudio.org/]
Trac Hacker [http://trac.edgewall.org/]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists