[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CC20923.8050400@neli.hopto.org>
Date: Fri, 22 Oct 2010 23:58:59 +0200
From: Micha Nelissen <micha@...i.hopto.org>
To: "Bounine, Alexandre" <Alexandre.Bounine@....com>
CC: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org,
Matt Porter <mporter@...nel.crashing.org>,
Li Yang <leoli@...escale.com>,
Kumar Gala <galak@...nel.crashing.org>,
Thomas Moll <thomas.moll@...go.com>
Subject: Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches
Bounine, Alexandre wrote:
> Micha Nelissen <micha@...i.hopto.org> wrote:
>> rswitch->rdev->destid should be the id associated with a given switch,
>> so that every (processor) device can agree what id some switch has.
>
> If we will need to identify the same physical switch by different
> processors we may use the component tag which now is unique for every
> device.
Yes, identification is the point. I think it might be confusing to have
a destid *and* a component tag id which are slightly different. The
destid is unambiguous (if you know whether the device is a switch or
endpoint) so I think it makes sense to use that if possible.
> This actually gives me another idea: instead of using global
> next_switchid counter make rswitch->switchid = component_tag and
> switches in sysfs will look identical for every processor (or just get
> rid of rswitch->switchid and use component_tag directly for switches).
I still prefer the destid as the single identification id.
Micha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists