linux-kernel - Re: [GIT PULL] first round of SCSI updates for the merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Oct 2010 15:13:10 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] first round of SCSI updates for the merge window

On Sat, Oct 23, 2010 at 2:48 PM, Roland Dreier <rdreier@...co.com> wrote:
>  > There's a _single_ commit that looks like this:
>  >
>  >  220 files changed, 34823 insertions(+), 43478 deletions(-)
>
> Hey, you're not using git properly... if I use '-M' to show moved
> files, I see:
>
>  212 files changed, 30007 insertions(+), 38662 deletions(-)
>
> which is a lot nicer.

It really doesn't make any difference what-so-ever. Lookie here:

  wc $(git ls-files drivers/scsi/bfa/)
  ...
  42946  114109 1118020 total

IOW, that driver only has 42k lines to begin with (well, it does now,
it used to have a few more). Whether there were a couple of files that
were similar enough after the fact to count as renames or not is
totally immaterial. The driver was basically rewritten or re-indented
or whatever, AND THE CHANGELOG DOESN'T EVEN _BEGIN_ TO EXPLAIN IT!

It's a two-line changelog, which isn't even accurate!

Two lines of explanation! For 70 _thousand_ lines of changes? The fact
that Bottomley signed off on that kind of crap, and then sent it on to
me with a oneline "cleanup" commentary should say something. And what
it says to me is "Never again". If I get stuff like this again, I stop
pulling. Those SCSI drivers might as well be outside the kernel tree,
there's no point having them in the tree if they are just code-drops.
It really isn't as if they have enough users to merit being there
anyway.

Because that kind of shit is simply not acceptable in the kernel. We
don't just do random undocumented code-drops. And dammit, James should
have known better.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/