linux-kernel - Re: [PATCH 04/21] fs: Implement lazy LRU updates for inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101023093259.GL19804@ZenIV.linux.org.uk>
Date:	Sat, 23 Oct 2010 10:32:59 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Dave Chinner <david@...morbit.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/21] fs: Implement lazy LRU updates for inodes

On Thu, Oct 21, 2010 at 11:49:29AM +1100, Dave Chinner wrote:
>  		if (sb->s_flags & MS_ACTIVE) {
> +			inode->i_state |= I_REFERENCED;
> +			if (!(inode->i_state & (I_DIRTY|I_SYNC))) {
> +				list_del_init(&inode->i_list);
> +				inode_lru_list_add(inode);

What if it was on the list already?  Looks like you'll screw the counter...
And yes, you have solution later in series (do nothing if list isn't empty);
should be here for bisectability sake...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/