linux-kernel - Re: [GIT PULL] Revert of the IO stat fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik4qAzZPLO8HHBCM34_NLEEdPj04RyXPfeR-wSv@mail.gmail.com>
Date:	Sun, 24 Oct 2010 13:35:33 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Revert of the IO stat fix

On Sun, Oct 24, 2010 at 1:09 PM, Jens Axboe <jaxboe@...ionio.com> wrote:
>
> The fix for cross-partition merges screwing up disk stats turns out
> to be problematic on various levels. Lets revert this one so we have
> time to come up with a proper solution for this.

Hmm.. I think the reverted patch looks like it really is the right
thing to do, so I hate reverting it this early. What were the problems
with it?

Btw, one thing that seems to be missing in the original commit (which
is not necessarily the reason for the trouble, of course), is that
elv_rq_merge_ok() seems to not check the partition. As far as I can
tell, we should have a

    if (req->part != bio->bi_bdev->bd_part)
       return 0;

there, no? And you should _not_ set rq->part in "drive_stat_acct()",
you should set it from bio->bi_bdev->bd_part when you create the
request.

(And if it is NULL, just don't do partition accounting at all)

Hmm? What am I missing? What were the bugs?

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/