linux-kernel - Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101024.150905.39179588.davem@davemloft.net>
Date:	Sun, 24 Oct 2010 15:09:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mkl@...gutronix.de
Cc:	masa-korg@....okisemi.com, andrew.chih.howe.khor@...el.com,
	sameo@...ux.intel.com, margie.foster@...el.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	socketcan-core@...ts.berlios.de, kok.howg.ewe@...el.com,
	wg@...ndegger.com, morinaga526@....okisemi.com,
	joel.clark@...el.com, yong.y.wang@...el.com, chripell@...e.org,
	qi.wang@...el.com
Subject: Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver
 to 2.6.35

From: Marc Kleine-Budde <mkl@...gutronix.de>
Date: Mon, 25 Oct 2010 00:05:25 +0200

> On 10/24/2010 11:43 PM, David Miller wrote:
>> From: Masayuki Ohtak <masa-korg@....okisemi.com>
>> Date: Fri, 15 Oct 2010 22:00:28 +0900
>> 
>>> CAN driver of Topcliff PCH
>>>
>>> Topcliff PCH is the platform controller hub that is going to be used in
>>> Intel's upcoming general embedded platform. All IO peripherals in
>>> Topcliff PCH are actually devices sitting on AMBA bus. 
>>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>>
>>> Signed-off-by: Masayuki Ohtake <masa-korg@....okisemi.com>
>> 
>> Applied, thanks.
> 
> IMHO this driver needs some improvements. There are some open points
> from Wolfgangs and my review. On the other side, it's a new driver and
> there's some time left before it hits mainline.

When people have more than a week to review and provide feedback,
and don't, I have zero sympathy especially this early in the
release cycle.

So if adding it to the tree is what I have to do to get you guys to
post your comments and suggest fixes, then that's what I am going to
(continue) to do. :-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/