linux-kernel - Re: [PATCH 02/15] x86, apic: Fix lapic mapping with construct ISA and visws mptable path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1010241146210.2466@localhost6.localdomain6>
Date:	Sun, 24 Oct 2010 11:47:53 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/15] x86, apic: Fix lapic mapping with construct ISA
 and visws mptable path

On Sat, 23 Oct 2010, Yinghai Lu wrote:

> Do need to set lapic mapping for them
> 
> in arch/x86/kernel/visws_quirks.c:
> we only have visws_find_smp_config() to set mp_lapic_addr to APIC_DEFAULT_PHYS_BASE
> visws_get_smp_config() is nop call.
> default_get_smp_config/check_physptr/smp_read_mpc is not called in the path.
> So smp_register_lapic_address() is not called, and lapic is not mapped.

-ENOPARSE. visws maps the APIC itself already in cobalt_init()

> in arch/x86/kernel/mpparse.c
> if mpf->feature1 != 0, it will go through contruct_default_ISA_mptable instead
> of check_phystr path, so smp_register_lapic_address is not called.
> 
> Those pathes all have smp_found_config set.
> 
> So need to remove !smp_found_config checking

Need ? You can, because the check is redundant if I understand the
above correctly.

Thanks,

	tglx

> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> ---
>  arch/x86/kernel/apic/apic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 4638396..193e407 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1677,7 +1677,7 @@ void __init init_apic_mappings(void)
>  		 * acpi lapic path already maps that address in
>  		 * acpi_register_lapic_address()
>  		 */
> -		if (!acpi_lapic && !smp_found_config)
> +		if (!acpi_lapic)
>  			set_fixmap_nocache(FIX_APIC_BASE, apic_phys);
>  
>  		apic_printk(APIC_VERBOSE, "mapped APIC to %08lx (%08lx)\n",
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/