linux-kernel - Re: [PATCH 04/15] x86, apic: Remove early_init_lapic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1010241150340.2466@localhost6.localdomain6>
Date:	Sun, 24 Oct 2010 11:53:31 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/15] x86, apic: Remove early_init_lapic_mapping

On Sat, 23 Oct 2010, Yinghai Lu wrote:

> It is almost the same as smp_register_lapic_addr()
> 
> Just need to make smp_read_mpc() call smp_register_lapic_addr when early==1.

> @@ -289,17 +289,13 @@ static int __init smp_read_mpc(struct mpc_table *mpc, unsigned early)
>  #ifdef CONFIG_X86_32
>  	generic_mps_oem_check(mpc, oem, str);
>  #endif
> -	/* save the local APIC address, it might be non-default */
> +	/* Initialize the lapic mapping */
>  	if (!acpi_lapic)
> -		mp_lapic_addr = mpc->lapic;
> +		smp_register_lapic_address(mpc->lapic);

How is this restricted to early == 1 ? It's called unconditionally
which is nonsense.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/