linux-kernel - Re: loop warnings in current git HEAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC4043F.1070605@redhat.com>
Date:	Sun, 24 Oct 2010 12:02:39 +0200
From:	Milan Broz <mbroz@...hat.com>
To:	Christoph Hellwig <hch@....de>
CC:	jaxboe@...ionio.com, linux-kernel@...r.kernel.org
Subject: Re: loop warnings in current git HEAD



On 10/23/2010 05:59 PM, Christoph Hellwig wrote:

> The loop driver in current git HEAD is rather unhappy when running
> xfstests.  I gets lots of warnings like the one below.  The most likely
> culprit seems to be:
>
> 	loop: add some basic read-only sysfs attributes
>
> (commit ee86273062cbb310665fe49e1f1937d2cf85b0b9) 
yes, seems I forgot bdev can be NULL in destructor (autoclear mode).
can you try if patch below helps?

Milan

loop: Properly clear sysfs in autoclear mode

Signed-off-by: Milan Broz <mbroz@...hat.com>

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 6c48b35..c21d4f3 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
 	if (bdev)
 		invalidate_bdev(bdev);
 	set_capacity(lo->lo_disk, 0);
+	loop_sysfs_exit(lo);
 	if (bdev) {
 		bd_set_size(bdev, 0);
-		loop_sysfs_exit(lo);
 		/* let user-space know about this change */
 		kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
 	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/