linux-kernel - Re: [PATCH] time: jiffies.c: fix typos in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1010241618480.8736@localhost6.localdomain6>
Date:	Sun, 24 Oct 2010 16:22:57 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Serafeim Zanikolas <sez@...ian.org>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] time: jiffies.c: fix typos in comment



On Sat, 23 Oct 2010, Serafeim Zanikolas wrote:

> 
> Signed-off-by: Serafeim Zanikolas <sez@...ian.org>
> ---
>  kernel/time/jiffies.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..12ba9a7 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -30,8 +30,8 @@
>   * the timer interrupt frequency HZ and it suffers
>   * inaccuracies caused by missed or lost timer
>   * interrupts and the inability for the timer
> - * interrupt hardware to accuratly tick at the
> - * requested HZ value. It is also not reccomended
> + * interrupt hardware to accurately tick at the
> + * requested HZ value. It is also not recommended
>   * for "tick-less" systems.

You are not only correcting a typo. You are changing the sense of the
comment, unfortunately in the wrong way.

Why wouldn't it be recommended that the interrupt hardware ticks at
the requested HZ value ? 

The inability of it to tick accurately at the requested HZ value is
one of the causes which make jiffies clocksource inaccurate. And that
what the comment says.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/