linux-kernel - Re: [PATCH 08/12] hwmon: lis3: Adjust fuzziness for 8 bit device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CC443C4.1040700@tremplin-utc.net>
Date:	Sun, 24 Oct 2010 16:33:40 +0200
From:	Éric Piel <eric.piel@...mplin-utc.net>
To:	Samu Onkalo <samu.p.onkalo@...ia.com>
CC:	khali@...ux-fr.org, guenter.roeck@...csson.com, jic23@....ac.uk,
	lm-sensors@...sensors.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/12] hwmon: lis3: Adjust fuzziness for 8 bit device

Op 22-10-10 13:57, Samu Onkalo schreef:
> Default fuziness is set smaller for 8 device.
> In 12 bit device LSB is quite close to 1 mg
> (mg = 1 / 1000 of earth gravity).
> In 8bit device LSB is about 18 mg.
> Set fuziness to 1 for 8 bit device.
>
> Signed-off-by: Samu Onkalo<samu.p.onkalo@...ia.com>
Acked-by: Eric Piel <eric.piel@...mplin-utc.net>
> ---
>   drivers/hwmon/lis3lv02d.c |   18 ++++++++++++++----
>   1 files changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/lis3lv02d.c b/drivers/hwmon/lis3lv02d.c
> index d66cbe1..7555091 100644
> --- a/drivers/hwmon/lis3lv02d.c
> +++ b/drivers/hwmon/lis3lv02d.c
> @@ -71,8 +71,10 @@
>   #define LIS3_SENSITIVITY_12B		((LIS3_ACCURACY * 1000) / 1024)
>   #define LIS3_SENSITIVITY_8B		(18 * LIS3_ACCURACY)
>
> -#define LIS3_DEFAULT_FUZZ		3
> -#define LIS3_DEFAULT_FLAT		3
> +#define LIS3_DEFAULT_FUZZ_12B		3
> +#define LIS3_DEFAULT_FLAT_12B		3
> +#define LIS3_DEFAULT_FUZZ_8B		1
> +#define LIS3_DEFAULT_FLAT_8B		1
>
>   struct lis3lv02d lis3_dev = {
>   	.misc_wait   = __WAIT_QUEUE_HEAD_INITIALIZER(lis3_dev.misc_wait),
> @@ -530,8 +532,16 @@ int lis3lv02d_joystick_enable(void)
>
>   	set_bit(EV_ABS, input_dev->evbit);
>   	max_val = (lis3_dev.mdps_max_val * lis3_dev.scale) / LIS3_ACCURACY;
> -	fuzz = (LIS3_DEFAULT_FUZZ * lis3_dev.scale) / LIS3_ACCURACY;
> -	flat = (LIS3_DEFAULT_FLAT * lis3_dev.scale) / LIS3_ACCURACY;
> +	if (lis3_dev.whoami == WAI_12B) {
> +		fuzz = LIS3_DEFAULT_FUZZ_12B;
> +		flat = LIS3_DEFAULT_FLAT_12B;
> +	} else {
> +		fuzz = LIS3_DEFAULT_FUZZ_8B;
> +		flat = LIS3_DEFAULT_FLAT_8B;
> +	}
> +	fuzz = (fuzz * lis3_dev.scale) / LIS3_ACCURACY;
> +	flat = (flat * lis3_dev.scale) / LIS3_ACCURACY;
> +
>   	input_set_abs_params(input_dev, ABS_X, -max_val, max_val, fuzz, flat);
>   	input_set_abs_params(input_dev, ABS_Y, -max_val, max_val, fuzz, flat);
>   	input_set_abs_params(input_dev, ABS_Z, -max_val, max_val, fuzz, flat);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/