linux-kernel - Re: [PATCH] loop: Properly clear sysfs in autoclear mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=PupMfGGQXpeM94p+idrSWh3Oqca0MuYtVnCKm@mail.gmail.com>
Date:	Mon, 25 Oct 2010 20:41:54 +0800
From:	Jeff Chua <jeff.chua.linux@...il.com>
To:	Milan Broz <mbroz@...hat.com>
Cc:	axboe@...nel.dk, hch@....de, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] loop: Properly clear sysfs in autoclear mode

On Mon, Oct 25, 2010 at 3:11 PM, Milan Broz <mbroz@...hat.com> wrote:
> In autoclear mode bdev is NULL but the sysfs
> entry should be destroyed otherwise this warning appears:
>
> WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0x82/0x95()
> sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop'
>
> Fixes commit ee86273062cbb310665fe49e1f1937d2cf85b0b9
>
> Signed-off-by: Milan Broz <mbroz@...hat.com>
> ---
>  drivers/block/loop.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 6c48b35..c21d4f3 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev)
>        if (bdev)
>                invalidate_bdev(bdev);
>        set_capacity(lo->lo_disk, 0);
> +       loop_sysfs_exit(lo);
>        if (bdev) {
>                bd_set_size(bdev, 0);
> -               loop_sysfs_exit(lo);
>                /* let user-space know about this change */
>                kobject_uevent(&disk_to_dev(bdev->bd_disk)->kobj, KOBJ_CHANGE);
>        }

Tested and worked.

Thanks,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/