linux-kernel - Re: [PATCH] wireless/wl1271: remove redundant if-statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288012245.21130.24.camel@chilepepper>
Date:	Mon, 25 Oct 2010 16:10:45 +0300
From:	Luciano Coelho <luciano.coelho@...ia.com>
To:	Nicolas Kaiser <nikai@...ai.net>
Cc:	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement

On Mon, 2010-10-25 at 00:24 +0200, ext Larry Finger wrote:
> On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> > Apparently the return value of wl1271_ps_elp_sleep never gets
> > checked anyway.
> 
> The patch is fine, but this comment is a little misleading as
> wl1271_ps_elp_sleep() is void and cannot return a value.

Yes, this patch is good, but please rewrite the description, as Larry
suggested.

-- 
Cheers,
Luca.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/