linux-kernel - Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Oct 2010 01:31:19 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option

2010-10-25 (월), 08:59 -0700, David Miller:
> From: Namhyung Kim <namhyung@...il.com>
> Date: Tue, 26 Oct 2010 00:52:37 +0900
> 
> > Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
> > SPARC because they're under SPARC64 too. Supporting
> > perf_event needs atomic64 operations but AFAIK sparc32
> > doesn't provide them, CMIIW. ;-) Also removes redundant
> > HAVE_IRQ_WORK line.
> > 
> > Signed-off-by: Namhyung Kim <namhyung@...il.com>
> 
> The generic non-hw perf event stuff builds fine on sparc32,
> please don't remove this unless you have a legitimate build
> failure to report and fix.
> 
> Even if sparc32 doesn't provide atomic64_t support, it very
> easily could do so using include/asm-generic/atomic64.h which
> implements them using spinlocks.

Now I see following build failure without this patch. Maybe some work is
needed to deal with atomic64_t. I'll try to prepare for it soon. Thanks.


  CC      arch/sparc/kernel/setup_32.o
In file included from arch/sparc/include/asm/local64.h:1:0,
                 from include/linux/perf_event.h:465,
                 from include/linux/ftrace_event.h:8,
                 from include/trace/syscall.h:6,
                 from include/linux/syscalls.h:76,
                 from arch/sparc/kernel/setup_32.c:23:
include/asm-generic/local64.h:62:2: error: expected
                            specifier-qualifier-list before 'atomic64_t'
In file included from include/linux/ftrace_event.h:8:0,
                 from include/trace/syscall.h:6,
                 from include/linux/syscalls.h:76,
                 from arch/sparc/kernel/setup_32.c:23:
include/linux/perf_event.h:722:2: error: expected
                            specifier-qualifier-list before 'atomic64_t'
include/linux/perf_event.h: In function 'perf_fetch_caller_regs':
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
                                           named 'tstate'
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
                                           named 'tpc'
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
                                           named 'tnpc'
include/linux/perf_event.h:1004:2: error: 'struct pt_regs' has no member
                                           named 'tpc'
make[3]: *** [arch/sparc/kernel/setup_32.o] Error 1
make[2]: *** [arch/sparc/kernel] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2


-- 
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/