lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Oct 2010 10:55:36 -0700 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Axel Lin <axel.lin@...il.com> Cc: linux-kernel <linux-kernel@...r.kernel.org>, Liam Girdwood <lrg@...mlogic.co.uk>, MyungJoo Ham <myungjoo.ham@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com> Subject: Re: [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage On Mon, Oct 25, 2010 at 10:17:06AM +0800, Axel Lin wrote: > In current implementation, vid is declared as u8, > then "vid == -1" is always false, and "vid >= 0" is always true. > Thus change it to s8. > > vid is always less than MAX8952_NUM_DVS_MODE in current implementation, > thus remove the cheking for "vid < MAX8952_NUM_DVS_MODE". This bit seems like reasonable paranoia in the face of future code changes and we're not really in a sufficiently fast path to worry about cycles - are you sure that this is essential? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists