linux-kernel - Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101025.115527.226780270.davem@davemloft.net>
Date:	Mon, 25 Oct 2010 11:55:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	namhyung@...il.com
Cc:	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option

From: Namhyung Kim <namhyung@...il.com>
Date: Tue, 26 Oct 2010 01:31:19 +0900

> 2010-10-25 (¿ù), 08:59 -0700, David Miller:
>> From: Namhyung Kim <namhyung@...il.com>
>> Date: Tue, 26 Oct 2010 00:52:37 +0900
>> 
>> > Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config
>> > SPARC because they're under SPARC64 too. Supporting
>> > perf_event needs atomic64 operations but AFAIK sparc32
>> > doesn't provide them, CMIIW. ;-) Also removes redundant
>> > HAVE_IRQ_WORK line.
>> > 
>> > Signed-off-by: Namhyung Kim <namhyung@...il.com>
>> 
>> The generic non-hw perf event stuff builds fine on sparc32,
>> please don't remove this unless you have a legitimate build
>> failure to report and fix.
>> 
>> Even if sparc32 doesn't provide atomic64_t support, it very
>> easily could do so using include/asm-generic/atomic64.h which
>> implements them using spinlocks.
> 
> Now I see following build failure without this patch. Maybe some work is
> needed to deal with atomic64_t. I'll try to prepare for it soon. Thanks.

Nevermind, I see the issue.  Ok, your patch is fine:

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/