linux-kernel - Re: [PATCH v2 1/2] Export usb_serial_generic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101025224045.GB26070@localhost>
Date:	Tue, 26 Oct 2010 00:40:45 +0200
From:	Johan Hovold <jhovold@...il.com>
To:	Alon Ziv <alon@...aviz.org>
Cc:	Alon Ziv <alon+git@...aviz.org>, linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] Export usb_serial_generic_write_room for use in
 modules

On Mon, Oct 25, 2010 at 09:57:37PM +0200, Alon Ziv wrote:
> Hi Johan,
> 
> On 10/25/2010 01:20 PM, you wrote:
> >> Any module using usb_serial_generic_write (which is already exported)
> >> had better use usb_serial_generic_write_room as well, or be prepared
> >> for failures.
> >
> > As I mentioned elsewhere, this description is a little misleading as any
> > driver can use the generic write_room implementation simply by not
> > overriding it (i.e. leaving the write_room field undefined).
> >
> > There is nothing wrong with exporting it, but it is currently only your
> > other patch that requires that. Could you perhaps just modify the patch
> > description?
> >
> Well... the latest changes (due to your review) removed even my driver's
> use of this function. So probably there is no need to export it (at
> least not yet).
> 
> If you prefer that I leave the export in place (and unused), I will
> clarify the patch description.

There's no need to export it unless it's got a use (and it's easily done
later should need arise).

I'm off for a week to UK (Embedded Linux Conference and some holidays)
with limited mail access from tomorrow so I'll have to get back to you
on your other mail when I'm back.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/