linux-kernel - Re: [PATCH 01/10] arch/x86/kernel/apic/io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.30.1010260114570.30853-100000@mail.perches.com>
Date:	Tue, 26 Oct 2010 01:23:59 -0700 (PDT)
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Jiri Kosina <trivial@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] arch/x86/kernel/apic/io_apic.c: Typo fix WARNING

On Tue, 26 Oct 2010, Ingo Molnar wrote:
> >  arch/x86/kernel/apic/io_apic.c |    2 +-
> > -		printk(KERN_WARNING "WARING: Max # of I/O APICs (%d) exceeded "
> > +		printk(KERN_WARNING "WARNING: Max # of I/O APICs (%d) exceeded "
> >  		       "(found %d), skipping\n", MAX_IO_APICS, nr_ioapics);
> While you are touching this please fix the other glaring problem this printk has.

There are 14 of these split lines formats in io_apic.c,
19 in apic and 1 in x2apic_uv_x.c.

There are also many apic_printk calls without KERN_<level>.

I prefer changing all of them at the same time rather
than 1 at a time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/