linux-kernel - Re: [PATCH v3] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101026111322.738b0b14@endymion.delvare>
Date:	Tue, 26 Oct 2010 11:13:22 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
Cc:	"Samuel Ortiz" <sameo@...ux.intel.com>,
	"Wolfram Sang" <w.sang@...gutronix.de>,
	"Ralf Baechle" <ralf@...ux-mips.org>, <linux-i2c@...r.kernel.org>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"Ben Dooks \(embedded platforms\)" <ben-linux@...ff.org>,
	"Linus Walleij" <linus.walleij@...ricsson.com>,
	"srinidhi kasagar" <srinidhi.kasagar@...ricsson.com>,
	"Tomoya MORINAGA" <morinaga526@....okisemi.com>,
	"Wang Qi\"" <qi.wang@...el.com>,
	"Wang Yong Y\"" <yong.y.wang@...el.com>, <kok.howg.ewe@...el.com>,
	<joel.clark@...el.com>, <andrew.chih.howe.khor@...el.com>
Subject: Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36

On Tue, 26 Oct 2010 18:05:07 +0900, Tomoya MORINAGA wrote:
> On Tuesday, October 26, 2010 5:20 PM, Jean Delvare wrote:
> 
> > I don't like this driver name at all. For one thing, "pch" is too
> > short. Many other vendors could come up with names with acronym "PCH".
> >
> > For another, Intel has many PCH (Platform Controller Hub) chips, some
> > of them (5/3400 Series, Cougar Point, Patsburg) are or will be
> > supported by the i2c-i801 driver, some of them (Moorestown) will be
> > supported by the upcoming i2c-intel-mid driver (even though the name
> > "PCH" is surprisingly missing from the source code) and your driver
> > only supports one particular model.
>
> Yes, this driver suppors only Topcliff(Intel Atom E6xx series) now.
>
> > So please find a name which accurately represents the hardware your
> > driver is for. i2c-topcliff would be fine with me, but you will have to
> > check with Intel, as I know they are quite picky with the usage of code
> > names.
> 
> Most drivers for Topcliff have been accepted with "pch_" prefix.

If other maintainers like their subsystem to be messy and confusing, up
to them ;)

> Only SPI driver, like you indicates, have accepted as spi_topcliff_pch.c.
> If you request,  I can modify "pch_i2c.c" to "i2c-topcliff_pch.c".

The _pch becomes redundant then, i2c-topcliff.c would be enough, but
both are fine with me, as my initial concern is gone.

> > As for the driver code, I will not be able to review it, sorry. It's
> > not in my area, I don't have the time and I don't have the hardware. I
> > think it would make sense for Intel people to review and test it before
> > it gets upstream.
>
> No problem!
> After reviewing by Intel(:CCed), we started posting to LKML and
> we have already tested this patch on the EVA Board.
> 
> Tuhs, I want you to merge to this patch to 2.6.37 ASAP.

There's no Reviewed-by, Acked-by or Signed-off-by from anyone at Intel
in the patch you posted. Which, as far as I am concerned, means that
nobody at Intel looked at the code so far. If this is incorrect, please
resend the patch with the appropriate acknowledgments and driver
history, so that it is clearer, who did what.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/