linux-kernel - Re: Adding more stuff to devres.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CC69FBA.1010001@kernel.org>
Date:	Tue, 26 Oct 2010 11:30:34 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Alexey Zaytsev <alexey.zaytsev@...il.com>, bphilips@...e.de
CC:	Kernel development list <linux-kernel@...r.kernel.org>,
	Kumar Gala <galak@...nel.crashing.org>
Subject: Re: Adding more stuff to devres.

Adding Brandon, Hi.

On 10/25/2010 05:52 PM, Alexey Zaytsev wrote:
> Would it be a good idea to get things other than resources managed by
> the devres?
> 
> In my probe() method, I still have to handle alloc_netdev() and
> mdiobus_alloc(). Adding corresponding devm_ functions should be
> trivial. So, should I prepare the patches, or is there something wrong
> with the approach?

Hmmm... Unless alloc_netdev() and mdiobus_alloc() are allocating
something special, I think it probably would be better to make them
use devres.  Please take a look at how ata_host_alloc() and
ata_host_start() are doing it.

IIRC, Brandon spent some time thinking about how use devres on network
drivers.  Brandon, any ideas?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/