linux-kernel - Re: [PATCH] archs: add ioremap_change_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Oct 2010 15:14:23 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, x86@...nel.org,
	Tim Bird <tim.bird@...sony.com>, andi@...stfloor.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] archs: add ioremap_change_write_prot

> Sorry to re-open the topic, but I'd like to receive any
> comments/feedback about this patch.

The name of the wrapper seems wrong -- this has nothing to do with IO.

I must admit I'm also not a fan of wrappers, why not call the set_memory_*
functions directly and implement them for the other archs too?

Other than that it seems reasonable.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/