linux-kernel - Re: #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101026154800.18c5cfe6@lxorguk.ukuu.org.uk>
Date:	Tue, 26 Oct 2010 15:48:00 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Elvis Dowson <elvis.dowson@....com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Luciano Coelho <luciano.coelho@...ia.com>
Subject: Re: #ifdef CONFIG_ checks not working

On Tue, 26 Oct 2010 18:28:22 +0400
Elvis Dowson <elvis.dowson@....com> wrote:

> Hi,
>        I just noticed that with the 2.6.36-rc8 kernel, the #ifdef checks aren't working. 

They seem to be working fine

> So for example, if I add the following code fragment in my omap3_beagle_init function, CONFIG_WL1271 doesn't get detected, even though in my .config file, CONFIG_WL1271=m.

You are checking for Y/N not for modular (check how other drivers check
for both)

> Would you happen to know why this is not working. This type of checks used to work with the 2.6.32 kernel versions.
> 
> #ifdef CONFIG_WL1271
>     printk(KERN_INFO "%s: CONFIG_WL1271 detected\n", __func__);
> #else
>     printk(KERN_INFO "%s: CONFIG_WL1271 not detected\n", __func__);
> #endif

The code looks wrong anyway - if you didn't compile it in then presumably
you *did* detect it but didn't have a driver ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/