linux-kernel - Re: [PATCH resend] Add sc16is7x2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101026155934.7e70a57c@lxorguk.ukuu.org.uk>
Date:	Tue, 26 Oct 2010 15:59:34 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Greg KH <greg@...ah.com>
Cc:	Manuel Stahl <manuel.stahl@....fraunhofer.de>,
	linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH resend] Add sc16is7x2 driver

> > And huh, "grep -R serial_max3100.h *" gives what? Only max3100.c
> > So do we need to remove serial_max3100.h as it's not used anywhere else?
> 
> Yup, that sounds like a great idea, I'll go queue up that patch when I
> get back from my travels at the moment.

Sounds a very bad idea to me. The point of the platform data objects
throughout the kernel is to allow other devices to use the driver without
having to hack it up. Removing these interfaces breaks that.

So NAK such a change. The existing code is right, the fact that the
interface isn't being used in that way visibly by currently merged code
doesn't mean it shouldn't be there.

Also max3100 has an active maintainer so perhaps you should Cc them on
such discussion ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/