| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1288106493.18238.82.camel@gandalf.stny.rr.com> Date: Tue, 26 Oct 2010 11:21:33 -0400 From: Steven Rostedt <rostedt@...dmis.org> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, mingo@...hat.com, hpa@...or.com, rusty@...tcorp.com.au, fweisbec@...il.com, srostedt@...hat.com, tglx@...utronix.de, Li Zefan <lizf@...fujitsu.com> Subject: Re: [tip:perf/urgent] tracing: Prevent unloadable modules from using trace_bprintk() On Tue, 2010-10-26 at 08:06 -0700, Linus Torvalds wrote: > On Tue, Oct 26, 2010 at 3:21 AM, tip-bot for Steven Rostedt > <srostedt@...hat.com> wrote: > > > > tracing: Prevent unloadable modules from using trace_bprintk() > > I still don't think this patch makes sense. > > Some of it is just totally insane. The CONFIG_MODVERSIONS check is > just crazy. MODVERSIONS has nothing what-so-ever to do with the issue. > > Don't do this. It's total voodoo programming. Yeah, I think Ingo pulled this by mistake (I asked him to do some pull requests, and this was probably mixed in the real ones). I purposely pulled it out of my other pull requests so we could debate it more. The right answer is what Li Zefan said and that is to simply flush the ring buffer on module removal if the module uses a trace_bprintk(). We already do this for tracepoints. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists