linux-kernel - Re: [PATCH 02/29] memstick: core: reorder functions This patch just reorders functions in memstick.c So that host specific and card driver specific functions are now grouped together. This makes it easier to understand the code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288055663.4024.25.camel@maxim-laptop>
Date:	Tue, 26 Oct 2010 03:14:23 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Alex Dubov <oakad@...oo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/29] memstick: core: reorder functions This patch
 just reorders functions in memstick.c So that host specific and card driver
 specific functions are now grouped together. This makes it easier to
 understand the code.

On Mon, 2010-10-25 at 07:50 -0700, Alex Dubov wrote:
> 
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> 
> > From: Maxim Levitsky <maximlevitsky@...il.com>
> > Subject: [PATCH 02/29] memstick: core: reorder functions This patch just reorders functions in memstick.c So that host specific and card driver specific functions are now grouped together. This makes it easier to understand the code.
> 
> 
> I'm not sure this purely subjective patch is of any real utility.
> And at any rate, it belongs to the end of the patchset (where the clean-up
> normally go), not to the beginning.

Could somebody else comment on this?
I mean memstick.c/h contains two types of functions.
One is useful only for low level drivers, and other only for high level
drivers. Whats wrong with at least grouping that together?
It probably even better to put them to separate files...

As for doing that late, I exaplained that once in reply to Morton.
It was much easier to split patches this way, and really doesn't matter
otherwise.

Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/