linux-kernel - Re: Dynamic nop selection breaks boot on Geode LX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikiQHLAM9GwMF8+spW-RgG9-=rducMLaThQmE+i@mail.gmail.com>
Date:	Tue, 26 Oct 2010 21:08:27 +0100
From:	Daniel Drake <dsd@...top.org>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Andres Salomon <dilinger@...ued.net>, Chris Ball <cjb@...top.org>,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org, mingo@...e.hu,
	hpa@...or.com, nick.lowe@...il.com, Borislav Petkov <bp@...en8.de>,
	tglx@...utronix.de
Subject: Re: Dynamic nop selection breaks boot on Geode LX

Hi,

On 4 October 2010 16:46, Jason Baron <jbaron@...hat.com> wrote:
> Hi Daniel,
>
> looks like I moved dynamic no-op selection way too early in the boot -
> before the exception tables required to select invalid opcodes were
> even set up. The patch belows moves them later and should resolve this
> issue for you. thanks for narrowing it down!

Bump... This patch has not been merged. I see that there is still some
lack of consensus in this area but please don't forget about it. The
offending commit (f49aa448561fe) has ended up in Linus' tree, so
Linus' tree does not boot on Geode as a result.

>
>
> move arch_init_ideal_nop5 later
>
> arch_init_ideal_nop5() was being called from setup_arch() before
> the exception table was setup. Move it later into
> alternative_instructions().
>
> Fixes a boot hang on OLPC's XO-1 laptop based on Geode LX
> processor.
>
>
> Reported-by: Daniel Drake <dsd@...top.org>
> Signed-off-by: Jason Baron <jbaron@...hat.com>
> ---
>  arch/x86/kernel/alternative.c |    5 +++++
>  arch/x86/kernel/setup.c       |    6 ------
>  2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
> index cb0e6d3..d8b5b21 100644
> --- a/arch/x86/kernel/alternative.c
> +++ b/arch/x86/kernel/alternative.c
> @@ -454,6 +454,7 @@ extern struct paravirt_patch_site __start_parainstructions[],
>
>  void __init alternative_instructions(void)
>  {
> +       unsigned long flags;
>        /* The patching is not fully atomic, so try to avoid local interruptions
>           that might execute the to be patched code.
>           Other CPUs are not running. */
> @@ -508,6 +509,10 @@ void __init alternative_instructions(void)
>                                (unsigned long)__smp_locks_end);
>
>        restart_nmi();
> +
> +       local_irq_save(flags);
> +       arch_init_ideal_nop5();
> +       local_irq_restore(flags);
>  }
>
>  /**
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 468ccd2..85b02b6 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -112,7 +112,6 @@
>  #include <asm/numa_64.h>
>  #endif
>  #include <asm/mce.h>
> -#include <asm/alternative.h>
>
>  /*
>  * end_pfn only includes RAM, while max_pfn_mapped includes all e820 entries.
> @@ -690,7 +689,6 @@ void __init setup_arch(char **cmdline_p)
>  {
>        int acpi = 0;
>        int k8 = 0;
> -       unsigned long flags;
>
>  #ifdef CONFIG_X86_32
>        memcpy(&boot_cpu_data, &new_cpu_data, sizeof(new_cpu_data));
> @@ -1038,10 +1036,6 @@ void __init setup_arch(char **cmdline_p)
>        x86_init.oem.banner();
>
>        mcheck_init();
> -
> -       local_irq_save(flags);
> -       arch_init_ideal_nop5();
> -       local_irq_restore(flags);
>  }
>
>  #ifdef CONFIG_X86_32
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/