linux-kernel - Re: [PATCH 19/29] memstick: jmb38x_ms: add register read/write functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288059586.4024.164.camel@maxim-laptop>
Date:	Tue, 26 Oct 2010 04:19:46 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Alex Dubov <oakad@...oo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/29] memstick: jmb38x_ms: add register read/write
 functions

On Mon, 2010-10-25 at 09:03 -0700, Alex Dubov wrote:
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> 
> > From: Maxim Levitsky <maximlevitsky@...il.com>
> > Subject: [PATCH 19/29] memstick: jmb38x_ms: add register read/write functions
> > To: "Alex Dubov" <oakad@...oo.com>
> > Cc: "Andrew Morton" <akpm@...ux-foundation.org>, "LKML" <linux-kernel@...r.kernel.org>, "Maxim Levitsky" <maximlevitsky@...il.com>
> > Received: Friday, 22 October, 2010, 4:53 PM
> > All over the code it is a bit easier
> > to see the
> > register access with this patch. Also set/clear mask
> > helpers refactor code a bit, but the biggest reason
> > for this patch is to make it possible to trace register
> > read/writes with a flip of a module param.
> > 
> > Currently these functions are unused, but will be by later
> > code
> > 
> > Signed-off-by: Maxim Levitsky <maximlevitsky@...il.com>
> 
> This looks like a case of:
> 1. You've run into a technical difficulty.
> 2. You used some temporary code to resolve and document it.
> 3. Now this temporary code is forever here to stay.
What? What you are accusing me of?
This is just an insult.

Having a simple way to trace register writes is always a good thing.

Also I have very similar code in ene_ir and r852. No complains.

Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/