linux-kernel - Re: [PATCH] drivers/in,put/mouse/psmouse-base.c: fix messages to point to existing file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101027082657.GA28895@core.coreip.homeip.net>
Date:	Wed, 27 Oct 2010 01:26:58 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	KOBAYASHI Yoshitake <yoshitake.kobayashi@...hiba.co.jp>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/in,put/mouse/psmouse-base.c: fix messages to
 point to existing file

Hi Yoshitake,

On Wed, Oct 27, 2010 at 08:16:28AM +0100, KOBAYASHI Yoshitake wrote:
> This patch makes it easier to find the file.
> 
> Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@...hiba.co.jp>
> ---
>  drivers/input/mouse/psmouse-base.c |   36 ++++++++++++++++++++++++------------
>  1 files changed, 24 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
> index 73a7af2..ecc476d 100644
> --- a/drivers/input/mouse/psmouse-base.c
> +++ b/drivers/input/mouse/psmouse-base.c
> @@ -251,11 +251,13 @@ static int psmouse_handle_byte(struct psmouse *psmouse)
>  	switch (rc) {
>  	case PSMOUSE_BAD_DATA:
>  		if (psmouse->state == PSMOUSE_ACTIVATED) {
> -			printk(KERN_WARNING "psmouse.c: %s at %s lost sync at byte %d\n",
> +			printk(KERN_WARNING
> +				"psmouse-base.c: %s at %s lost sync at byte %d\n",
>  				psmouse->name, psmouse->phys, psmouse->pktcnt);
>  			if (++psmouse->out_of_sync_cnt == psmouse->resetafter) {
>  				__psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> -				printk(KERN_NOTICE "psmouse.c: issuing reconnect request\n");
> +				printk(KERN_NOTICE
> +					"psmouse-base.c: issuing reconnect request\n");

Thank you very much for your patch, however I have a patch from Joe
Perches in my queue that converts input devices to use pr_err() and
similar helpers and KBUILD_BASENAME as format prefix. This will produce
result similar to your patch but is more maintenable since the messages
need not be updated if they are moved or source file is renamed.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/